Messages in this thread | | | Date | Wed, 10 Aug 2005 08:43:38 +0100 | From | Christoph Hellwig <> | Subject | Re: GFS |
| |
On Wed, Aug 10, 2005 at 10:40:37AM +0300, Pekka J Enberg wrote: > Hi David, > > >+ return -EINVAL; > >+ if (!access_ok(VERIFY_WRITE, buf, size)) > >+ return -EFAULT; > >+ > >+ if (!(file->f_flags & O_LARGEFILE)) { > >+ if (*offset >= 0x7FFFFFFFull) > >+ return -EFBIG; > >+ if (*offset + size > 0x7FFFFFFFull) > >+ size = 0x7FFFFFFFull - *offset; > > Please use a constant instead for 0x7FFFFFFFull. (Appears in various other > places as well.)
In fact this very much looks like it's duplicating generic_write_checks(). Folks, please use common code.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |