Messages in this thread | | | Date | Mon, 1 Aug 2005 15:17:51 +0200 | From | Jens Axboe <> | Subject | Re: [PATCH linux-2.6-block:master] block: fix cfq_find_next_crq |
| |
On Tue, Jul 26 2005, Tejun Heo wrote: > Hi, > > In cfq_find_next_crq(), when determining rbnext, if > rb_next(&last->rb_node) is NULL, rb_first() is used without checking > if it equals last. If it equals last, rbnext should be NULL not last. > This bug is masked by duplicate calls to cfq_find_next_crq which ends > up clearing cfqq->next_crq as, on the second call, last isn't on rb > tree. > > This patch fixes cfq_find_next_crq() and removes extra calls to > cfq_update_next_crq().
Thanks, looks good!
-- Jens Axboe
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |