Messages in this thread | | | Date | Mon, 1 Aug 2005 21:51:48 +0100 (BST) | From | Hugh Dickins <> | Subject | Re: [patch 2.6.13-rc4] fix get_user_pages bug |
| |
On Mon, 1 Aug 2005, Andrew Morton wrote: > static inline int handle_mm_fault(...) > { > int ret = __handle_mm_fault(...); > > if (unlikely(ret == VM_FAULT_RACE)) > ret = VM_FAULT_MINOR; > return ret; > } > because VM_FAULT_RACE is some internal private thing. > It does add another test-n-branch to the pagefault path though.
Good idea, at least to avoid changing all arches at this moment; though I don't think handle_mm_fault itself can be static inline.
But let's set this VM_FAULT_RACE approach aside for now: I think we're agreed that the pte_dirty-with-mods-to-s390 route is more attractive, so I'll now try to find fault with that approach.
Hugh - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |