lkml.org 
[lkml]   [2005]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[2.6 patch] drivers/media/video/tveeprom.c: possible cleanups
This patch contains the following possible cleanups:
- make two needlessly global structs static
- #if 0 the EXPORT_SYMBOL'ed but unused function tveeprom_dump

Signed-off-by: Adrian Bunk <bunk@stusta.de>

---

This patch was already sent on:
- 19 Apr 2005

drivers/media/video/tveeprom.c | 6 ++++--
include/media/tveeprom.h | 1 -
2 files changed, 4 insertions(+), 3 deletions(-)

--- linux-2.6.12-rc2-mm3-full/include/media/tveeprom.h.old 2005-04-19 01:41:24.000000000 +0200
+++ linux-2.6.12-rc2-mm3-full/include/media/tveeprom.h 2005-04-19 01:41:28.000000000 +0200
@@ -20,4 +20,3 @@
unsigned char *eeprom_data);

int tveeprom_read(struct i2c_client *c, unsigned char *eedata, int len);
-int tveeprom_dump(unsigned char *eedata, int len);
--- linux-2.6.12-rc2-mm3-full/drivers/media/video/tveeprom.c.old 2005-04-19 01:40:39.000000000 +0200
+++ linux-2.6.12-rc2-mm3-full/drivers/media/video/tveeprom.c 2005-04-19 01:41:13.000000000 +0200
@@ -453,6 +453,7 @@
}
EXPORT_SYMBOL(tveeprom_read);

+#if 0
int tveeprom_dump(unsigned char *eedata, int len)
{
int i;
@@ -468,6 +469,7 @@
return 0;
}
EXPORT_SYMBOL(tveeprom_dump);
+#endif /* 0 */

/* ----------------------------------------------------------------------- */
/* needed for ivtv.sf.net at the moment. Should go away in the long */
@@ -484,7 +486,7 @@
};
I2C_CLIENT_INSMOD;

-struct i2c_driver i2c_driver_tveeprom;
+static struct i2c_driver i2c_driver_tveeprom;

static int
tveeprom_command(struct i2c_client *client,
@@ -556,7 +558,7 @@
return 0;
}

-struct i2c_driver i2c_driver_tveeprom = {
+static struct i2c_driver i2c_driver_tveeprom = {
.owner = THIS_MODULE,
.name = "tveeprom",
.id = I2C_DRIVERID_TVEEPROM,
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-07-09 05:20    [W:0.025 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site