lkml.org 
[lkml]   [2005]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [2.6 patch] unexport phys_proc_id and cpu_core_id
On Thu, Jun 02, 2005 at 05:12:50PM -0400, Dave Jones wrote:
> On Thu, Jun 02, 2005 at 10:48:14PM +0200, Adrian Bunk wrote:
> > On Sat, May 07, 2005 at 03:45:07PM +0200, Andi Kleen wrote:
> > > On Fri, May 06, 2005 at 11:19:14PM +0200, Adrian Bunk wrote:
> > > > Back in January, Andi Kleen added EXPORT_SYMBOL(phys_proc_id), stating:
> > > > This is needed for the powernow k8 driver to manage AMD dual core
> > > > systems.
> > > >
> > > > This EXPORT_SYMBOL was never used.
> > > >
> > > > I asked him on 13 Mar 2005 whether it's really required, but he didn't
> > > > answer to my email.
> > >
> > > It is superceeded now with cpu_core_map[]/cpu_core_id[]
> > > >
> > > > 2.6.12-rc3 adds cpu_core_id with a similarly unused
> > > > EXPORT_SYMBOL(cpu_core_id).
> > > >
> > > > It's OK to export symbols when these exports are required, but unless
> > > > someone can explain why they are required now, they should be removed
> > > > before 2.6.12 and then re-added when they are actually used.
> > >
> > > The dual powernowk8 driver really uses them, although the merging
> > > process seems to be a bit slow.
> > >
> > > Andrew, please don't apply the patch.
> >
> > Is there any time when you expect to submit the dual powernowk8 driver
> > you've added the EXPORT_SYMBOL for five months ago?
> >
> > I'd prefer if we'd not add EXPORT_SYMBOL's before the potential users
> > are available...
>
> powernow-k8 dual-core support got merged a few days ago.

My patch to unexport these two variables wouldn't break it today...

> Dave

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-07-09 05:18    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site