lkml.org 
[lkml]   [2005]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] tpm: Support for new chip type
Hello!

On Fri, Jul 08, 2005 at 12:42:02AM +0200, Marcel Selhorst wrote:
> +++ linux/drivers/char/tpm/tpm_infineon.c 2005-07-07 14:56:27.000000000 +0000
...
> + * Specifications at www.trustedcomputinggroup.org
Blanks at end of line

> +/* Infineon specific delay definitions */
> +enum infineon_tpm_delay {
> + TPM_MAX_WTX_PACKAGES = 50, /* maximum number of WTX-packages */
> + TPM_WTX_MSLEEP_TIME = 20, /* msleep-Time for WTX-packages */
> + TPM_MSLEEP_TIME = 3, /* msleep-Time --> Interval to check status register */
> + TPM_MAX_TRIES = 5000 /* gives number of max. msleep()-calls before
> + throwing timeout */
> +};
These look like unrelated constants, perhaps #define would be nicer?

> +static int wait(struct tpm_chip *chip, int wait_for_bit)
> +{
> +
blank line

> +}
> +static void tpm_inf_cancel(struct tpm_chip *chip)
missing blank line

> +static int __init tpm_inf_probe(struct pci_dev *pci_dev,
> + const struct pci_device_id *pci_id)
> +{
> +
blank lines
> + return 0;
> +
> + } else {

BYtE
Philipp
--
/ / (_)__ __ ____ __ Philipp Hahn
/ /__/ / _ \/ // /\ \/ /
/____/_/_//_/\_,_/ /_/\_\ pmhahn@titan.lahn.de
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-07-08 08:59    [W:0.069 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site