lkml.org 
[lkml]   [2005]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch 1/4] drivers/char/ip2/i2lib.c: replace direct assignment with set_current_state()
    domen@coderock.org wrote:
    >
    > @@ -655,7 +655,7 @@ i2QueueCommands(int type, i2ChanStrPtr p
    > timeout--; // So negative values == forever
    >
    > if (!in_interrupt()) {

    I worry about what this driver is trying to do...

    > - current->state = TASK_INTERRUPTIBLE;
    > + set_current_state(TASK_INTERRUPTIBLE);
    > schedule_timeout(1); // short nap

    We do this all over the place. Adding new schedule_timeout_interruptible()
    and schedule_timeout_uninterruptible() would reduce kernel size and neaten
    things up.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-07-09 01:16    [W:5.378 / U:0.172 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site