Messages in this thread | | | Date | Fri, 8 Jul 2005 16:08:24 -0700 | From | Andrew Morton <> | Subject | Re: [patch 1/4] drivers/char/ip2/i2lib.c: replace direct assignment with set_current_state() |
| |
domen@coderock.org wrote: > > @@ -655,7 +655,7 @@ i2QueueCommands(int type, i2ChanStrPtr p > timeout--; // So negative values == forever > > if (!in_interrupt()) {
I worry about what this driver is trying to do...
> - current->state = TASK_INTERRUPTIBLE; > + set_current_state(TASK_INTERRUPTIBLE); > schedule_timeout(1); // short nap
We do this all over the place. Adding new schedule_timeout_interruptible() and schedule_timeout_uninterruptible() would reduce kernel size and neaten things up. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |