Messages in this thread | | | Date | Wed, 6 Jul 2005 18:41:19 -0500 | From | Doug Warzecha <> | Subject | Re: [PATCH] char: Add Dell Systems Management Base driver |
| |
On Wed, Jul 06, 2005 at 09:07:37AM -0700, Greg KH wrote: > On Wed, Jul 06, 2005 at 10:57:35AM -0500, Doug Warzecha wrote: > > On Tue, Jul 05, 2005 at 11:17:03PM -0500, Greg KH wrote: > > > > +static void dcdbas_device_release(struct device *dev) > > > > +{ > > > > + /* nothing to release */ > > > > +} > > > > > > This is a symptom of a broken driver. > > > > > > Hm, I wonder if there's some way for the compiler to check the fact that > > > a function pointer passed to another function, is really a null > > > function. That would stop this kind of nonsense... > > > > There are other drivers in the kernel tree with null device release functions. > > Where?
Here's a couple:
drivers/video/vfb.c: vfb_platform_release drivers/video/epson1355fb.c: epson1355fb_platform_release
Doug - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |