lkml.org 
[lkml]   [2005]   [Jul]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [patch] call device_shutdown with interrupts enabled
    Pavel Machek wrote:
    > Do not call device_shutdown with interrupts disabled. It is wrong and
    > produces ugly warnings.

    Hm. How about (possible whitespace damage):

    --- linux/kernel/power/disk.c~ 2005-07-04 08:26:47.000000000 +0200
    +++ linux/kernel/power/disk.c 2005-07-04 08:27:45.000000000 +0200
    @@ -53,19 +53,17 @@ static void power_down(suspend_disk_meth
    unsigned long flags;
    int error = 0;

    + device_shutdown();
    local_irq_save(flags);
    switch(mode) {
    case PM_DISK_PLATFORM:
    - device_shutdown();
    error = pm_ops->enter(PM_SUSPEND_DISK);
    break;
    case PM_DISK_SHUTDOWN:
    printk("Powering off system\n");
    - device_shutdown();
    machine_power_off();
    break;
    case PM_DISK_REBOOT:
    - device_shutdown();
    machine_restart(NULL);
    break;
    }

    --
    Stefan Seyfried \ "I didn't want to write for pay. I
    QA / R&D Team Mobile Devices \ wanted to be paid for what I write."
    SUSE LINUX Products GmbH, Nürnberg \ -- Leonard Cohen

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-07-04 09:28    [W:0.030 / U:189.144 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site