Messages in this thread | | | Date | Sat, 30 Jul 2005 23:32:20 +0200 | From | Folkert van Heusden <> | Subject | Re: [PATCH] random : prefetch the whole pool, not 1/4 of it |
| |
> Could you check this patch and apply it ? > [RANDOM] : prefetch the whole pool, not 1/4 of it, > (pool contains u32 words, not bytes) > Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>
> --- linux-2.6.13-rc3/drivers/char/random.c 2005-07-13 06:46:46.000000000 +0200 > +++ linux-2.6.13-rc3-ed/drivers/char/random.c 2005-07-29 00:11:24.000000000 +0200 > @@ -469,7 +469,7 @@ > next_w = *in++; > > spin_lock_irqsave(&r->lock, flags); > - prefetch_range(r->pool, wordmask); > + prefetch_range(r->pool, wordmask*4);
Isn't it cleaner to replace the line above with: + prefetch_range(r->pool, wordmask * sizeof(__u32)); as the pool contains u32 words?
> input_rotate = r->input_rotate; > add_ptr = r->add_ptr; >
Folkert van Heusden
-- Auto te koop, zie: http://www.vanheusden.com/daihatsu.php -------------------------------------------------------------------- Get your PGP/GPG key signed at www.biglumber.com! -------------------------------------------------------------------- Phone: +31-6-41278122, PGP-key: 1F28D8AE [unhandled content-type:application/pgp-signature] | |