Messages in this thread | | | From | Denis Vlasenko <> | Subject | Re: [PATCH] all-arch delay functions take 2 | Date | Sun, 3 Jul 2005 17:27:27 +0300 |
| |
On Sunday 03 July 2005 17:14, Jesper Juhl wrote: > On 7/3/05, Denis Vlasenko <vda@ilport.com.ua> wrote: > > Hi folks, > > > > This patch makes mdelay/udelay/ndelay calls as small > > as possible (just a function call), uses macros which > > do compile-time checks on delay duration if parameter > > is a constant, otherwise check is done at run time > > to prevent udelay(-1) disasters. > > > [snip] > > > > > -#define ndelay(n) udelay((n) * 5) > > +//BOGUS! #define ndelay(n) udelay((n) * 5) > > > If it's bogus, why not just remove it instead of leaving it in as a > comment (and a C++ style comment at that) ?
I wanted to draw attention of someone who knows what's going on. Can be removed altogether instead.
> [snip] > > +//extern struct timer_opts* timer; > > Why add this at all if you are just going to comment it out anyway?
Sorry, this is a leftover meant to be deleted. -- vda
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |