lkml.org 
[lkml]   [2005]   [Jul]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] all-arch delay functions take 2
On 7/3/05, Denis Vlasenko <vda@ilport.com.ua> wrote:
> Hi folks,
>
> This patch makes mdelay/udelay/ndelay calls as small
> as possible (just a function call), uses macros which
> do compile-time checks on delay duration if parameter
> is a constant, otherwise check is done at run time
> to prevent udelay(-1) disasters.
>
[snip]

>
> -#define ndelay(n) udelay((n) * 5)
> +//BOGUS! #define ndelay(n) udelay((n) * 5)
>
If it's bogus, why not just remove it instead of leaving it in as a
comment (and a C++ style comment at that) ?

[snip]
> +//extern struct timer_opts* timer;

Why add this at all if you are just going to comment it out anyway?



--
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-07-03 16:17    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site