![]() | |||||||||||||
Messages in this thread |
On Sunday 03 July 2005 14:41, Herbert Xu wrote: > On Mon, Jun 20, 2005 at 01:59:23PM +0300, Denis Vlasenko wrote: > > > > @@ -265,10 +263,10 @@ aes_set_key(void *ctx_arg, const u8 *in_ > > > > ctx->key_length = key_len; > > > > - E_KEY[0] = u32_in (in_key); > > - E_KEY[1] = u32_in (in_key + 4); > > - E_KEY[2] = u32_in (in_key + 8); > > - E_KEY[3] = u32_in (in_key + 12); > > + E_KEY[0] = load_le32(in_key,0); > > + E_KEY[1] = load_le32(in_key,1); > > + E_KEY[2] = load_le32(in_key,2); > > + E_KEY[3] = load_le32(in_key,3); > > Please insert a space after the comma. The second param is an index in implicit vector. Sably store_xxx and load_xxx syntax makes that non-obvious. I deliberately did not put space there, trying to give reader a hint that "dst,n" part is really "dst[n]": store_le32(dst,0, a); // like "dst[0] = a" but with (u32*) cast on dst + le32 conversion on a store_le32(dst,1, b); Do you still want space added? -- vda - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ | ||||||||||||
| Last update: 2005-07-03 14:19 [from the cache] ©2003-2008 | |||||||||||||