Messages in this thread | | | Subject | Re: [RFC][PATCH] libata ATAPI alignment | From | Alan Cox <> | Date | Fri, 29 Jul 2005 14:38:54 +0100 |
| |
On Gwe, 2005-07-29 at 01:06 -0400, Jeff Garzik wrote: > So, one thing that's terribly ugly about SATA ATAPI is that we need to > pad DMA transfers to the next 32-bit boundary, if the length is not > evenly divisible by 4.
Looks good and avoids the special case leaking into the core code.
> Complicating matters, we currently must support two methods of data > buffer submission: a single kernel virtual address, or a struct > scatterlist.
For the moment - also you turn the single buffer into a one entry sglist so its not to bad.
> Review is requested by any and all parties, as well as suggestions for > a prettier approach.
I'd pull the code into seperate functions but thats my only real comment. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |