![]() | |||||||||||
Messages in this thread |
Hi, On Thursday, 28 of July 2005 10:06, Takashi Iwai wrote: > At Wed, 27 Jul 2005 22:52:49 +0200, > Pavel Machek wrote: > > > > Hi! > > > > > > The following patch adds free_irq() and request_irq() to the suspend and > > > > resume, respectively, routines in the snd_intel8x0 driver. > > > > > > The patch looks OK to me although I have some concerns. > > > > > > - The error in resume can't be handled properly. > > > > > > What should we do for the error of request_irq()? > > > > > > - Adding this to all drivers seem too much. > > > > There's probably no other way. Talk to Len Brown. > > > > > We just need to stop the irq processing until resume, so something > > > like suspend_irq(irq, dev_id) and resume_irq(irq, dev_id) would be > > > more uesful? > > > > Its more complex than that. Irq numbers may change during resume. > > Hmm, then the patch looks wrong. It assumes that the irq number is > as same as before suspend. Well, that''s the theory, but frankly I don't see a practical reason. I have never seen this happening. Practically, for this to happen, you'll have to reconfigure the BIOS accross suspend/resume which is dangerous anyway. Greets, Rafael -- - Would you tell me, please, which way I ought to go from here? - That depends a good deal on where you want to get to. -- Lewis Carroll "Alice's Adventures in Wonderland" - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ | ||||||||||
| Last update: 2005-07-28 10:45 [from the cache] ©2003-2008 | |||||||||||