Messages in this thread | | | Date | Thu, 28 Jul 2005 13:22:14 -0700 | From | Mitchell Blank Jr <> | Subject | Re: [PATCH] driver core: Add the ability to unbind drivers to devices from userspace |
| |
Still one nitpick:
Jon Smirl wrote: > + while (isspace(*x) && (x - buffer->page < count)) > + x++;
I think you can just do:
if (count > 0) while (isspace(*x)) x++;
If the passed-in string was fully whitespace then the trailing-whitespace stripping would already reduce it to count==0. So as long as you check for that case you can be sure that the while() will stop before x falls off the end of the string.
Other than that it looks fine to me now.
-Mitch - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |