Messages in this thread | | | Date | Thu, 28 Jul 2005 16:32:03 +0200 | From | Adrian Bunk <> | Subject | Re: [PATCH] New include file for marking old style api files |
| |
On Thu, Jul 28, 2005 at 04:07:57PM +0200, Jiri Slaby wrote: > Adrian Bunk napsal(a): > > >On Thu, Jul 28, 2005 at 03:42:26PM +0200, Jiri Slaby wrote: > > > > > >>Hi. > >>Do you think, that this would be useful in the kernel tree? > >>I have an idea to mark old drivers, which should I or somebody rewrite. > >>For example drivers/isdn/hisax/gazel.c. > >>... > >>--- /dev/null > >>+++ b/include/linux/oldapi.h > >>@@ -0,0 +1,2 @@ > >>+#warning This driver uses old style API and needs to be rewritten or > >>removed \ > >>+ from kernel > >> > >> > > > >What's wrong with __deprecated ? > > > > > Nothing, but this marks entire driver, not a function, that it uses. > I.e. gazel doesn't emit any warning or so, I think; so for these cases.
Why do you require a header file for this? Simply put the #warning in gazel.c .
If the API is scheduled for removal, you should put the #warning in the header file for the API.
If the API is old but is expected to stay for a longer time, simply do nothing. Artificially increasing the warnings during kernel compilation only makes it harder to find important warnings.
cu Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |