Messages in this thread | | | Date | Wed, 27 Jul 2005 16:03:15 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH][1/3] ppc32: add 440ep support |
| |
Paul Mackerras <paulus@samba.org> wrote: > > Andrew Morton writes: > > > Matt Porter <mporter@kernel.crashing.org> wrote: > > > > > > +static u64 dma_mask = 0xffffffffULL; > > > > I'm sure you're totally uninterested in this, but the above will probably > > generate warnings on (say) ppc64, where u64 is implemented as unsigned > > long. > > > > I usually chuck a simple `-1' in there and the compiler always gets it > > right, regardless of signedness and size and architecture. > > Umm, I think we actually want 2^32-1 not -1, don't we?
Doh. Cant coun't.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |