lkml.org 
[lkml]   [2005]   [Jul]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [patch] inotify: ppc64 syscalls.
From
From: Robert Love <rml@novell.com>
Date: Wed, 27 Jul 2005 13:31:36 -0400

> [ I don't think we need sys32 compatibility versions--and if we do, I
> failed in life. ]

add_watch and rm_watch both do, because system call arguments are
zero-extended by default for compat tasks, thus the "fd" arg needs
sign extension.

You'll notice that sys_ppc32.c has a ton of shims which purely
exist to sign extend "int" system call arguments. Sparc64 does
something similarly, but in assembler so that we don't eat the
overhead of a full stack frame just to sign extend arguments.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-07-27 22:35    [from the cache]
©2003-2011 Jasper Spaans. Advertise on this site