Messages in this thread | | | Date | Tue, 26 Jul 2005 16:58:24 -0700 | From | Matt Mackall <> | Subject | Re: [2.6 patch] NETCONSOLE must depend on INET |
| |
On Tue, Jul 26, 2005 at 04:32:02PM -0700, David S. Miller wrote: > From: Matt Mackall <mpm@selenic.com> > Date: Tue, 26 Jul 2005 16:20:43 -0700 > > > This problem also exists in PKTGEN. And this fix is incorrect as > > neither is dependent on the IP part of the networking stack in any > > substantive way. The right fix is to make inet_aton available outside > > of CONFIG_INET (preferred) or making private copies of inet_aton. > > Adrian posted a fix, you whine, that's why Adrian's fix > went in :-)
Adrian's fix is the moral equivalent of throwing in a cast to shut up a compiler warning for a legitimate bug.
> More seriously, please submit a version of whatever you > believe to be the more correct fix so it can be reviewed > and integrated.
Do you have a preferred location to put this function or shall I invent one?
-- Mathematics is the supreme nostalgia of our time. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |