lkml.org 
[lkml]   [2005]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    SubjectRe: [PATCH] 1 Wire drivers illegally overload NETLINK_NFLOG
    From
    From: Harald Welte <laforge@netfilter.org>
    Date: Sat, 23 Jul 2005 09:33:53 -0400

    > I strongly disrecommend increasing NPROTO. Maybe we should look into
    > reusing NETLINK_FIREWALL (which was an old 2.2.x kernel interface).

    ip_queue.c still uses NETLINK_FIREWALL so we really can't use
    that.

    So instead, as in the patch below, I solved this for now by using
    the NETLINK_SKIP value which was reserved years ago yet never
    made use of.

    diff --git a/drivers/w1/w1_int.c b/drivers/w1/w1_int.c
    --- a/drivers/w1/w1_int.c
    +++ b/drivers/w1/w1_int.c
    @@ -88,7 +88,7 @@ static struct w1_master * w1_alloc_dev(u

    dev->groups = 23;
    dev->seq = 1;
    - dev->nls = netlink_kernel_create(NETLINK_NFLOG, NULL);
    + dev->nls = netlink_kernel_create(NETLINK_W1, NULL);
    if (!dev->nls) {
    printk(KERN_ERR "Failed to create new netlink socket(%u) for w1 master %s.\n",
    NETLINK_NFLOG, dev->dev.bus_id);
    diff --git a/include/linux/netlink.h b/include/linux/netlink.h
    --- a/include/linux/netlink.h
    +++ b/include/linux/netlink.h
    @@ -5,7 +5,7 @@
    #include <linux/types.h>

    #define NETLINK_ROUTE 0 /* Routing/device hook */
    -#define NETLINK_SKIP 1 /* Reserved for ENskip */
    +#define NETLINK_W1 1 /* 1-wire subsystem */
    #define NETLINK_USERSOCK 2 /* Reserved for user mode socket protocols */
    #define NETLINK_FIREWALL 3 /* Firewalling hook */
    #define NETLINK_TCPDIAG 4 /* TCP socket monitoring */
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2005-07-25 04:19    [W:8.159 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site