lkml.org 
[lkml]   [2005]   [Jul]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] generic_file_sendpage
Linus Torvalds wrote:
>
> "sendfile()" in general I think has been a mistake. It's too specialized,
> and the interface has always sucked.

Ok, you're right. I will have a look at the pipe buffer stuff.

> As Andrew pointed out, it actually
> needs to limit the number of buffers in flight partly because otherwise
> you have uninterruptible kernel work etc etc.

Hmm, sendfile() uses do_generic_mapping_read() which is calling the
file_send_actor() per page. The actor calls ->sendpage(). I don't see
any situation how this could lead to uninterruptible kernel work when
the sendpage() itself is checking for signals. There are only 2 pages in
flight in this case.

Jan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-07-20 21:04    [W:0.055 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site