lkml.org 
[lkml]   [2005]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[2.6 patch] sound drivers select'ing ISAPNP must depend on PNP && ISA
On Sun, Jul 17, 2005 at 05:07:48PM +0200, Bodo Eggert wrote:

> In sound/isa/Kconfig, select ISAPNP and depend on ISAPNP are intermixed,
> resulting in funny behaviour. (Soundcarts get selectable if other
> soundcards are selected).
>
> This patch changes the "depend on ISAPNP"s to select.
>...

I like the idea of this patch, but it brings to more drivers to a
violation of the "if you select something, you have to ensure that the
dependencies of what you select are fulfilled" rule causing link errors
with invalid .config's.

This patch (on top of your patch) fixes this problem.

Signed-off-by: Adrian Bunk <bunk@stusta.de>

---

sound/isa/Kconfig | 14 +++++++-------
1 files changed, 7 insertions(+), 7 deletions(-)

--- linux-2.6.13-rc3-mm1-full/sound/isa/Kconfig.old 2005-07-19 18:27:21.000000000 +0200
+++ linux-2.6.13-rc3-mm1-full/sound/isa/Kconfig 2005-07-19 18:28:44.000000000 +0200
@@ -15,7 +15,7 @@

config SND_AD1816A
tristate "Analog Devices SoundPort AD1816A"
- depends on SND
+ depends on SND && PNP && ISA
select ISAPNP
select SND_OPL3_LIB
select SND_MPU401_UART
@@ -81,7 +81,7 @@

config SND_ES968
tristate "Generic ESS ES968 driver"
- depends on SND
+ depends on SND && PNP && ISA
select ISAPNP
select SND_MPU401_UART
select SND_PCM
@@ -162,7 +162,7 @@

config SND_INTERWAVE
tristate "AMD InterWave, Gravis UltraSound PnP"
- depends on SND
+ depends on SND && PNP && ISA
select SND_RAWMIDI
select SND_CS4231_LIB
select SND_GUS_SYNTH
@@ -177,7 +177,7 @@

config SND_INTERWAVE_STB
tristate "AMD InterWave + TEA6330T (UltraSound 32-Pro)"
- depends on SND
+ depends on SND && PNP && ISA
select SND_RAWMIDI
select SND_CS4231_LIB
select SND_GUS_SYNTH
@@ -293,7 +293,7 @@

config SND_ALS100
tristate "Avance Logic ALS100/ALS120"
- depends on SND
+ depends on SND && PNP && ISA
select ISAPNP
select SND_OPL3_LIB
select SND_MPU401_UART
@@ -307,7 +307,7 @@

config SND_AZT2320
tristate "Aztech Systems AZT2320"
- depends on SND
+ depends on SND && PNP && ISA
select ISAPNP
select SND_OPL3_LIB
select SND_MPU401_UART
@@ -332,7 +332,7 @@

config SND_DT019X
tristate "Diamond Technologies DT-019X, Avance Logic ALS-007"
- depends on SND
+ depends on SND && PNP && ISA
select ISAPNP
select SND_OPL3_LIB
select SND_MPU401_UART
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-07-19 18:40    [W:0.103 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site