lkml.org 
[lkml]   [2005]   [Jul]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[-mm patch] fs/fscache/: cleanups
    This patch contains the following cleanups:
    - make needlessly global code static
    - main.c: remove the unused global variable fscache_debug

    Signed-off-by: Adrian Bunk <bunk@stusta.de>

    ---

    This patch was already sent on:
    - 20 Jun 2005
    - 23 Apr 2005

    fs/fscache/cookie.c | 19 +++++++++++++++----
    fs/fscache/fscache-int.h | 11 -----------
    fs/fscache/main.c | 2 --
    3 files changed, 15 insertions(+), 17 deletions(-)

    --- linux-2.6.12-rc2-mm3-full/fs/fscache/fscache-int.h.old 2005-04-23 02:53:14.000000000 +0200
    +++ linux-2.6.12-rc2-mm3-full/fs/fscache/fscache-int.h 2005-04-23 02:55:11.000000000 +0200
    @@ -22,17 +22,6 @@

    extern void fscache_cookie_init_once(void *_cookie, kmem_cache_t *cachep, unsigned long flags);

    -extern void __fscache_cookie_put(struct fscache_cookie *cookie);
    -
    -static inline void fscache_cookie_put(struct fscache_cookie *cookie)
    -{
    - BUG_ON(atomic_read(&cookie->usage) <= 0);
    -
    - if (atomic_dec_and_test(&cookie->usage))
    - __fscache_cookie_put(cookie);
    -
    -}
    -
    /*****************************************************************************/
    /*
    * debug tracing
    --- linux-2.6.12-rc2-mm3-full/fs/fscache/cookie.c.old 2005-04-23 02:53:26.000000000 +0200
    +++ linux-2.6.12-rc2-mm3-full/fs/fscache/cookie.c 2005-04-23 02:55:39.000000000 +0200
    @@ -12,14 +12,25 @@
    #include <linux/module.h>
    #include "fscache-int.h"

    -LIST_HEAD(fscache_netfs_list);
    -LIST_HEAD(fscache_cache_list);
    -DECLARE_RWSEM(fscache_addremove_sem);
    +static LIST_HEAD(fscache_netfs_list);
    +static LIST_HEAD(fscache_cache_list);
    +static DECLARE_RWSEM(fscache_addremove_sem);

    kmem_cache_t *fscache_cookie_jar;

    static void fscache_withdraw_node(struct fscache_cache *cache,
    struct fscache_node *node);
    +static void __fscache_cookie_put(struct fscache_cookie *cookie);
    +
    +
    +static inline void fscache_cookie_put(struct fscache_cookie *cookie)
    +{
    + BUG_ON(atomic_read(&cookie->usage) <= 0);
    +
    + if (atomic_dec_and_test(&cookie->usage))
    + __fscache_cookie_put(cookie);
    +
    +}

    /*****************************************************************************/
    /*
    @@ -925,7 +936,7 @@
    /*
    * destroy a cookie
    */
    -void __fscache_cookie_put(struct fscache_cookie *cookie)
    +static void __fscache_cookie_put(struct fscache_cookie *cookie)
    {
    struct fscache_search_result *srch;

    --- linux-2.6.12-rc2-mm3-full/fs/fscache/main.c.old 2005-04-23 02:55:48.000000000 +0200
    +++ linux-2.6.12-rc2-mm3-full/fs/fscache/main.c 2005-04-23 02:56:22.000000000 +0200
    @@ -16,8 +16,6 @@
    #include <linux/slab.h>
    #include "fscache-int.h"

    -int fscache_debug = 0;
    -
    static int fscache_init(void);
    static void fscache_exit(void);

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-07-17 17:03    [W:0.026 / U:32.868 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site