Messages in this thread | | | Date | Thu, 14 Jul 2005 22:00:42 +0200 | From | Francois Romieu <> | Subject | Re: [RFC][PATCH] split PCI probing code [1/9] |
| |
Greg KH <greg@kroah.com> : > On Thu, Jul 14, 2005 at 07:10:14PM +0200, Francois Romieu wrote: > > Adam Belay <abelay@novell.com> : > > [...] > > > > Some nits + a suspect error branch. It seems nice otherwise. > > If I'm correct, this patch only moves the code into different files, it > doesn't change any of it, so your comments apply to the current code > today, not Adam's changes :)
The summary of the serie advertised cleaner code (TM). I wish I could clean the clothes simply by moving them around.
[...] > > mm/slab.c provides kcalloc. > > Ick, I hate that function call, this is nicer :)
No problem. I just want to be sure that janitors have noticed it. O:o)
-- Ueimor - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |