Messages in this thread | | | Date | Wed, 13 Jul 2005 13:19:06 -0700 | From | Greg KH <> | Subject | Re: [PATCH] char: Add Dell Systems Management Base driver |
| |
On Tue, Jul 12, 2005 at 07:57:16PM -0500, Doug Warzecha wrote: > On Wed, Jul 06, 2005 at 11:07:37AM -0500, Greg KH wrote: > > On Wed, Jul 06, 2005 at 10:57:35AM -0500, Doug Warzecha wrote: > > > On Tue, Jul 05, 2005 at 11:17:03PM -0500, Greg KH wrote: > > > > > > > > I'm sure I commented on this driver already, yet, I never got a > > response > > > > and the code is not changed. Is there some reason for this? > > That's a > > > > sure way to prevent your patch from ever being applied... > > > > > > This is the first comment on the release function. The code has been > > > changing in response to comments from you and others. We'll continue > > > to make changes as needed. > > > > You never responded to those questions though, so determining if the > > code was changed is difficult. And I still see you using ioctls, which, > > if I remember, was what I asked about. > > > > The dcdbas driver has been shipping outside of the kernel tree for > some time now in support of the systems listed in the source and is > expected to support the listed systems for some time to come. The > driver has always used ioctls for Dell systems management software to > communicate with it.
Well, your code has always been wrong then :)
> The systems that are supported by the driver are > older Dell PowerEdge systems which contain Dell proprietary hardware > systems management interfaces. The latest shipping PowerEdge systems > support the standard IPMI hardware systems management interface which > can be accessed by the in-kernel standard IPMI driver (which uses > ioctls). Future PowerEdge systems are expected to support the IPMI > systems management interface as well.
Then only support the "new" interface for newer systems.
> Even though the dcdbas driver is not expected to be needed for future > PowerEdge systems, we would like to make it easier for Dell customers > to run Dell systems management software with the latest kernel on the > systems supported by the dcdbas driver by making the driver available > in the kernel tree. We would like to do that without impacting the > existing Dell systems management software for the older systems so > that we can focus our resources on the newer systems. > > Is it an absolute "must" that this driver not use ioctls?
Yes. Sorry.
thanks,
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |