lkml.org 
[lkml]   [2005]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Apple USB Touchpad driver (new)
Hi,

On 7/12/05, Stelian Pop <stelian@popies.net> wrote:
>
> + dev->input.id.bustype = BUS_USB;
> + dev->input.id.vendor = id->idVendor;
> + dev->input.id.product = id->idProduct;
> + dev->input.id.version = ATP_DRIVER_VERSION;
> +

Why don't we do what most of the other input devices and get version
from the device too? Actually we have this in input tree:

static inline void
usb_to_input_id(const struct usb_device *dev, struct input_id *id)
{
id->bustype = BUS_USB;
id->vendor = le16_to_cpu(dev->descriptor.idVendor);
id->product = le16_to_cpu(dev->descriptor.idProduct);
id->version = le16_to_cpu(dev->descriptor.bcdDevice);
}
--
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-07-12 16:20    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site