[lkml]   [2005]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH][help?] Radeonfb acpi resume
Matthew Garrett wrote:
> Micheal Marineau <> wrote:
>>+ if (pdev->dev.power.power_state != 4)
>>+ {
>>+ pci_restore_state (pdev);
>>+ acpi_vgapost (pdev->devfn);
>>+ }
> Please *don't* make this unconditional. There's no guarantee that the
> video BIOS is postable after initial system boot. A boot-time parameter
> to enable it seems reasonable, but in general we're likely to stand a
> much better chance getting it working in userspace.

A kernel parameter seems reasonable, I assume that pci_restore_state
shoule remain unconditional right? Userspace works just fine if
the frame buffer is not used, but it has to be done in kernel when
using a frame buffer.

Michael Marineau
Oregon State University
[unhandled content-type:application/pgp-signature]
 \ /
  Last update: 2005-07-12 15:54    [W:0.050 / U:6.496 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site