Messages in this thread | | | Date | Tue, 12 Jul 2005 06:39:54 -0700 | From | Micheal Marineau <> | Subject | Re: [PATCH][help?] Radeonfb acpi resume |
| |
Matthew Garrett wrote: > Micheal Marineau <marineam@engr.orst.edu> wrote: > > >>+ if (pdev->dev.power.power_state != 4) >>+ { >>+ pci_restore_state (pdev); >>+ acpi_vgapost (pdev->devfn); >>+ } > > > Please *don't* make this unconditional. There's no guarantee that the > video BIOS is postable after initial system boot. A boot-time parameter > to enable it seems reasonable, but in general we're likely to stand a > much better chance getting it working in userspace.
A kernel parameter seems reasonable, I assume that pci_restore_state shoule remain unconditional right? Userspace works just fine if the frame buffer is not used, but it has to be done in kernel when using a frame buffer.
-- Michael Marineau marineam@engr.orst.edu Oregon State University [unhandled content-type:application/pgp-signature] | |