lkml.org 
[lkml]   [2005]   [Jul]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH][help?] Radeonfb acpi resume
Thanks for the reply,

Pavel Machek wrote:
> Hi!
>
>
>>Aww crap, thunderbird screwed up the white space...
>>
>>A usable version of the patch is attached, or here is a link:
>>http://dev.gentoo.org/~marineam/files/patch-radeonfb-2.6.12
>
>
> Wrong indentation in acpi_vgapost; I remember there was better patch
> to fix this out there.
Ok, I'll go through and fix any coding style problems. I've only seen
older versions of this same patch, but if there is a better way I'd love
to hear it. I'll google around a little more just in case.

>
> Anyway, are you sure machine you have can't be fixed by any methods
> listed in Doc*/power/video.txt? I guess they are preferable to
> acpi_vgapost...
Actually, this is one of the metholds listed in video.txt. Take a look
at #7 ;-). I just tried acpi_sleep=s3_bios to see what that does, but
just caused an instant reboot on resume. The only other solutions that
works is to disable the frame buffer and use X or some other app to do
the job as listed in #5 and #6, but something in kernel like this patch
is required to be able to use the framebuffer.

>
> If not... indent it acording to the coding style and drop "phony
> return code" (it is unneeded, anyway, right?) and try again. (Oh and
> Cc me ;-).
> Pavel

Ok, I'll try it without. I don't know if it's needed or not, that code
is untouched from Ole Rohne's origional version.

--
Michael Marineau
marineam@engr.orst.edu
Oregon State University
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2005-07-11 21:01    [W:1.036 / U:1.660 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site