lkml.org 
[lkml]   [2005]   [Jul]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: share/private/slave a subtree - define vs enum
    Hi,

    On Mon, 11 Jul 2005, Horst von Brand wrote:

    > > I don't generally disagree with that, I just think that defines are not
    > > part of that list.
    >
    > Covered in "bad coding style" and "hard to read code", at least.

    Somehow I missed the last lkml debate about where simple defines where a
    problem.

    > > Look, it's great that you do reviews, but please keep in mind it's the
    > > author who has to work with code and he has to be primarily happy with,
    > > so you don't have to point out every minor issue.
    >
    > Wrong. The author has to work with the code, but there are much more people
    > that have to read it now and fix it in the future. It doesn't make sense
    > having everybody using their own indentation style, variable naming scheme,
    > and ways of defining constants.

    I didn't say this, I said "minor issues". Please read more carefully.

    bye, Roman
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-07-11 20:05    [W:0.025 / U:60.620 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site