lkml.org 
[lkml]   [2005]   [Jul]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] skge: remove unused declarations
    On Tue, Jun 28, 2005 at 12:16:44PM -0700, Linux Kernel wrote:
    > tree 6154380f95d261126525fc95eb149ddc8478eeea
    > parent 4707953454677f985289b4e4bcbea41f0cc651c2
    > author Stephen Hemminger <shemminger@osdl.org> Tue, 28 Jun 2005 01:33:08 -0700
    > committer Jeff Garzik <jgarzik@pobox.com> Tue, 28 Jun 2005 02:05:06 -0400
    >
    > [PATCH] skge: remove unused declarations
    >
    > Get rid of definitions for chip versions and PHY chips that
    > this driver does not support.
    >
    > Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
    > ...
    > - PCI_EN_DUMMY_RD = 1<<3, /* Enable Dummy Read */
    > - PCI_REV_DESC = 1<<2, /* Reverse Desc. Bytes */
    > - PCI_USEDATA64 = 1<<0, /* Use 64Bit Data bus ext */
    > -};

    This bit breaks PPC builds, due to ..

    3145 #ifdef __BIG_ENDIAN
    3146 /* byte swap decriptors in hardware */
    3147 {
    3148 u32 reg;
    3149
    3150 pci_read_config_dword(pdev, PCI_DEV_REG2, &reg);
    3151 reg |= 1 << 2; /* PCI_REV_DESC */
    3152 pci_write_config_dword(pdev, PCI_DEV_REG2, reg);
    3153 }
    3154 #endif

    For my builds, I've just hardcoded it, I don't know if you prefer
    to put the enum back or not..

    Dave
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-07-02 00:55    [W:0.037 / U:123.312 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site