Messages in this thread | | | Date | Wed, 8 Jun 2005 22:26:08 -0700 | From | Greg KH <> | Subject | Re: [RFC PATCH] PCI: remove access to pci_[enable|disable]_msi() for drivers |
| |
On Thu, Jun 09, 2005 at 06:54:31AM +0200, Stefan Smietanowski wrote: > > > > The issue is, if pci_enable_msix() fails, we want to fall back to MSI, > > so you need to call pci_enable_msi() for that (after calling > > pci_disable_msi() before calling pci_enable_msix(), what a mess...) > > > > So we still need both functions, and for MSI-X, the logic involved in > > enabling it is horrible. Let me see if this can be made saner... > > Why not make pci_switch_to_msix() (yeah, horrible name) instead? > > pci_switch_to_msix(dev) > { > pci_disable_msi(dev); > if (!psi_enable_msix(dev)) > pci_enable_msi(dev); > } > > And it can naturally inform the caller if it failed or not.
Yes, that would work, if you want to go down that path :)
After trying this all out, I'm convinced that we should just stick with what we have.
thanks,
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |