[lkml]   [2005]   [Jun]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 03/10] IOCHK interface for I/O error handling/detecting
    On Thu, Jun 09, 2005 at 09:51:57PM +0900, Hidetoshi Seto wrote:
    > + if( cookie->error || have_error(cookie->dev) )

    This should be written as:
    if (cookie->error || have_error(cookie->dev))
    instead (note the placement of spaces).

    > /* definition of ia64 iocookie */
    > -typedef unsigned long iocookie;
    > +struct __iocookie {
    > + struct list_head list;
    > + struct pci_dev *dev; /* targeting device */
    > + unsigned long error; /* error flag */
    > +};
    > +typedef struct __iocookie iocookie;

    Hm, why not just make the thing be a "struct iocookie" in the first
    place, then we don't have to mess with a typedef at all. And then each
    arch can define how the structure will look like in their private .c
    files, ensuring that no user can ever try to touch the structure


    greg k-h
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2005-06-09 19:02    [W:0.020 / U:0.096 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site