![]() | |||||||||||||
Messages in this thread |
On Tue, Jun 07, 2005 at 01:21:29PM -0700, Greg KH wrote: > Hm, here's an updated patch that should have fixed the errors I had in > my previous one where I wasn't disabling MSI for the devices that did > not want it enabled (note, my patch skips the hotplug and pcie driver > for now, those would have to be fixed if this patch goes on.) > > However, now that I've messed around with the MSI-X logic in the IB > driver, I'm thinking that this whole thing is just pointless, and I > should just drop it and we should stick with the current way of enabling > MSI only if the driver wants it. If you look at the logic in the mthca > driver you'll see what I mean. The problem is then that we have to go through all drivers and add the ugly logic there. Isnt it better to do it by default? > Oh, and in looking at the drivers/pci/msi.c file, it could use some > cleanups to make it smaller and a bit less complex. I've also seen some > complaints that it is very arch specific (x86 based). But as no other > arches seem to want to support MSI, I don't really see any need to split > it up. Any comments about this? I think it would be better to have a clean split. -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ | ||||||||||||
| Last update: 2005-06-08 13:34 [W:0.308 / U:0.160 seconds] ©2003-2008 Jasper Spaans | |||||||||||||