Messages in this thread | | | Subject | RE: [RFC PATCH] PCI: remove access to pci_[enable|disable]_msi() for drivers - take 2 | Date | Tue, 7 Jun 2005 15:40:48 -0700 | From | "Nguyen, Tom L" <> |
| |
On Tuesday, June 07, 2005 1:21 PM Greg KH wrote: > However, now that I've messed around with the MSI-X logic in the IB > driver, I'm thinking that this whole thing is just pointless, and I > should just drop it and we should stick with the current way of enabling > MSI only if the driver wants it. If you look at the logic in the mthca > driver you'll see what I mean. > >So, anyone else think this is a good idea? Votes for me to just drop it >and go back to hacking on the driver core instead?
I vote "no change".
> Oh, and in looking at the drivers/pci/msi.c file, it could use some > cleanups to make it smaller and a bit less complex. I've also seen some > complaints that it is very arch specific (x86 based). But as no other > arches seem to want to support MSI, I don't really see any need to split > it up. Any comments about this?
Agree.
Thanks, Long
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |