lkml.org 
[lkml]   [2005]   [Jun]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] Support for read-only MMC cards
    Russell King wrote:

    >On Sat, Jun 04, 2005 at 10:05:00PM +0200, Pierre Ossman wrote:
    >
    >
    >>Russell King wrote:
    >>
    >>
    >>>I'd prefer this to be:
    >>>
    >>> printk(KERN_INFO "%s: %s %s %dKiB%s\n",
    >>> md->disk->disk_name, mmc_card_id(card), mmc_card_name(card),
    >>> (card->csd.capacity << card->csd.read_blkbits) / 1024,
    >>> card->csd.cmdclass & CCC_BLOCK_WRITE ? "" : " (ro)");
    >>>
    >>>
    >>>
    >>>
    >>>
    >>I'd rather not since the SD patches have a similar test but on a
    >>different condition.
    >>
    >>
    >
    >That's just a case of adding another %s and ?:. I'd really prefer it
    >to be done this way.
    >
    >
    >

    Well that would turn out something like:

    printk(KERN_INFO "%s: %s %s %dKiB%s\n",
    md->disk->disk_name, mmc_card_id(card), mmc_card_name(card),
    (card->csd.capacity << card->csd.read_blkbits) / 1024,
    (!(card->csd.cmdclass & CCC_BLOCK_WRITE) ||
    mmc_card_readonly(card)) ? " (ro)" : "");

    which is a bit messy IMHO.

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-06-04 22:17    [W:0.027 / U:3.772 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site