lkml.org 
[lkml]   [2005]   [Jun]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: PCI Power management (was: Re: [PATCH 4/13]: PCI Err: e100 ethernet driver recovery
From
Date
On Thu, 2005-06-30 at 15:39 -0500, Linas Vepstas wrote:

> Thus, the right thing to do might be to split up the
> struct pci_dev->suspend() and pci_dev->resume() calls into
>
> suspend()
> poweroff()
> poweron()
> resume()

No. There are very good reasons not to do that split at the pci_dev
level.

> and then have the generic pci error recovery routines call
> suspend/resume only, skipping the poweroff-on calls. Does that
> sound good?
>
> I'm not sure I can pull this off without having someone from
> the power-management world throw a brick at me.

Just keep the error recovery callbacks for now, and we might be able to
provide a generic "helper" doing the watchdog thing (yes, there is a
watchdog in the net core)

Ben.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-07-01 01:44    [W:0.406 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site