Messages in this thread | | | Subject | Re: PCI Power management (was: Re: [PATCH 4/13]: PCI Err: e100 ethernet driver recovery | From | Benjamin Herrenschmidt <> | Date | Fri, 01 Jul 2005 09:32:43 +1000 |
| |
On Thu, 2005-06-30 at 15:39 -0500, Linas Vepstas wrote:
> Thus, the right thing to do might be to split up the > struct pci_dev->suspend() and pci_dev->resume() calls into > > suspend() > poweroff() > poweron() > resume()
No. There are very good reasons not to do that split at the pci_dev level.
> and then have the generic pci error recovery routines call > suspend/resume only, skipping the poweroff-on calls. Does that > sound good? > > I'm not sure I can pull this off without having someone from > the power-management world throw a brick at me.
Just keep the error recovery callbacks for now, and we might be able to provide a generic "helper" doing the watchdog thing (yes, there is a watchdog in the net core)
Ben.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |