Messages in this thread |  | | | Date | Wed, 29 Jun 2005 08:07:29 +0100 | | From | Christoph Hellwig <> | | Subject | Re: [PATCH 2/3] freevxfs: minor cleanups |
| |
On Tue, Jun 28, 2005 at 04:31:14PM -0700, Andrew Morton wrote: > Pekka Enberg <penberg@cs.helsinki.fi> wrote: > > > > This patch addresses the following minor issues: > > > > - Typo in printk > > - Redundant casts > > - Use C99 struct initializers instead of memset > > - Parenthesis around return value > > - Use inline instead of __inline__ > > That struct initialisation: > > > + *infp = (struct vxfs_sb_info) { > > + .vsi_raw = rsbp, > > + .vsi_bp = bp, > > + .vsi_oltext = rsbp->vs_oltext[0], > > + .vsi_oltsize = rsbp->vs_oltsize, > > + }; > > > > Is a bit unconventional, but it doesn't alter the size of the .o file, so > whatever.
It looks rather horrible, I wouldn't call that a cleanup. Where's the full patch? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |