Messages in this thread | | | From | Alexey Dobriyan <> | Subject | Re: [PATCH 1/1] V4L CX88 patch - against 2.6.12-mm2 | Date | Wed, 29 Jun 2005 02:10:54 +0400 |
| |
On Wednesday 29 June 2005 01:21, Jean Delvare wrote: > Your patch adds trailing whitespace in various places: [snip] > Six people signing this patch and nobody noticed? Amazing. > > Please fix, thanks.
Also:
> --- linux-2.6.12-mm2/drivers/media/video/cx88/cx88-core.c > +++ linux/drivers/media/video/cx88/cx88-core.c
> +/* Used only on cx88-core */ > static char *cx88_pci_irqs[32] = {
"static" already said that.
> +/* Used only on cx88-video */ > char *cx88_vid_irqs[32] = {
So move it there.
> +/* Used only on cx88-mpeg */ > char *cx88_mpeg_irqs[32] = {
Move this too.
> --- linux-2.6.12-mm2/drivers/media/video/cx88/cx88-input.c > +++ linux/drivers/media/video/cx88/cx88-input.c
> +static IR_KEYTAB_TYPE ir_codes_msi_tvanywhere[IR_KEYTAB_SIZE] = { > + [ 0x00 ] = KEY_0, /* '0' */ > + [ 0x01 ] = KEY_1, /* '1' */ > + [ 0x02 ] = KEY_2, /* '2' */ > + [ 0x03 ] = KEY_3, /* '3' */ > + [ 0x04 ] = KEY_4, /* '4' */ > + [ 0x05 ] = KEY_5, /* '5' */ > + [ 0x06 ] = KEY_6, /* '6' */ > + [ 0x07 ] = KEY_7, /* '7' */ > + [ 0x08 ] = KEY_8, /* '8' */ > + [ 0x09 ] = KEY_9, /* '9' */ > + [ 0x0c ] = KEY_MUTE, /* 'Mute' */
Duplicating comments.
> + [ 0x10 ] = KEY_F, /* 'Funtion' */
Function.
> + [ 0x12 ] = KEY_POWER, /* 'Power' */
> + [ 0x14 ] = KEY_SLOW, /* 'Slow' */
Duplicating comments. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |