lkml.org 
[lkml]   [2005]   [Jun]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: reiser4 merging action list
On Mon, Jun 27, 2005 at 04:00:01PM -0700, Hans Reiser wrote:
>
> Andrew asked me to put together a list of things that need to be done
> before merging:

...

> Probably I forget something.

I've started to do a very basic look over the tree and there's a few
more things that spring to mind:

- cpp abuse. There's quite a lot of really odd macros - the typesafe_list,
typesafe_hash stuff is mentioned already, but there's really horrible
stuff like _INIT_ and _DONE_ bits in init_super.c, and the wrappers for
plugin method invocations.
- endianess handling. The d* types are a lovely attempt to make sure
you're not missing endianess conversions. We have a more general
way to ensure that now using sparse, that's the __le* / __be* types.
Try running sparse -Wbitwise to find places you'll need that annotations
(after the normal sparse warnings are fixed, else you'll have a hard
time seeing them I guess) - after that the single element struct thing
can go away. Also you're defining a CPU_IN_DISK_ORDER macro that's
never used..
- lease use kthread_* instead of kernel_thread() + lots of opencoding
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-06-28 11:47    [W:0.418 / U:0.368 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site