Messages in this thread | | | Date | Tue, 21 Jun 2005 09:36:15 +0200 | From | Jörn Engel <> | Subject | Re: [patch 2/2] kernel/power/disk.c string fix and if-less iterator |
| |
On Tue, 21 June 2005 00:10:41 +0200, Pavel Machek wrote: > > > The attached patch: > > > > o Fixes kernel/power/disk.c string declared as 'char *p = "...";' to be > > declared as 'char p[] = "...";', as pointed by Jeff Garzik. > > ? Why was char *p ... wrong? Because you could not do sizeof() later?
Not necessarily wrong, but iirc, "*p" can waste 4 bytes (or 8, for 64-bit platforms). Since this variable isn't static, that's a non-issue, but I've seen it on some kernel-janitor list anyway.
Jörn
-- Those who come seeking peace without a treaty are plotting. -- Sun Tzu - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |