Messages in this thread | | | Date | Tue, 21 Jun 2005 13:20:37 -0700 | From | Tony Lindgren <> | Subject | Re: [PATCH 2.6.12] amd76x_pm: C2 powersaving for AMD K7 |
| |
* Joerg Sommrey <jo@sommrey.de> [050620 13:54]: > This is a processor idle module for AMD SMP 760MP(X) based systems. > The patch was originally written by Tony Lindgren and has been around > since 2002. It enables C2 mode on AMD SMP systems and thus saves > about 70 - 90 W of energy in the idle mode compared to the default idle > mode. The idle function has been rewritten and now should be free of > locking issues and is independent from the number of CPUs. The impact > from this module on the system clock has been reduced. > > This patch can also be found at > http://www.sommrey.de/amd76x_pm/amd_76x_pm-2.6.12-jo1.patch
Cool. Just once comment:
> +// #define AMD76X_NTH 1 > +// #define AMD76X_POS 1 > +// #define AMD76X_C3 1
How about separating all this ifdef code into a separate debug patch on top of the amd_76x_pm patch? Or just leave it out as I don't think anybody is using it. It would shrink down the patch quite a bit and make it more readable.
I won't be able to access my dual athlon box until September, so I'm not much of help with this module :)
Regards,
Tony - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |