lkml.org 
[lkml]   [2005]   [Jun]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: Moxa multi serial driver doesn't pass received chars up
    Date
    On Thursday 02 June 2005 12:20, Denis Vlasenko wrote:
    > Hi,
    >
    > I have to set up 8-port PCI multiport serial card.
    > Everything seems okay except for receive side.
    >
    > I added this to mxser.c: mxser_receive_chars()
    > at the bottom:
    >
    > mxvar_log.rxcnt[info->port] += cnt;
    > info->mon_data.rxcnt += cnt;
    > info->mon_data.up_rxcnt += cnt;
    > spin_unlock_irqrestore(&info->slock, flags);
    >
    > +if (verbose>1) {
    > +int c = cnt;
    > +unsigned char *p = tty->flip.char_buf;
    > +printk("mxser_receive_chars:");
    > +while(c--)
    > + printk(" %02x", *p++);
    > +printk("\n");
    > +}
    >
    > tty_flip_buffer_push(tty);
    > }

    No wonder... it directly stuffs chars into flip buffer,
    but does _not_ update flip counter!

    I am cooking a patch which will use

    tty_insert_flip_char(tty, ch, flag);

    instead...
    --
    vda

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-06-02 15:01    [W:0.023 / U:30.268 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site