Messages in this thread |  | | | From | Ingo Oeser <> | | Subject | Re: [rfc] [patch] consolidate/clean up spinlock.h files | | Date | Thu, 2 Jun 2005 17:49:15 +0200 |
| |
Hi Ingo, you wrote:
> --- linux/lib/spinlock_debug.c.orig > +++ linux/lib/spinlock_debug.c > +#define SPIN_BUG_ON(cond, lock, msg) \ > + if (unlikely(cond)) spin_bug(lock, __FILE__, __LINE__, msg) > +#define RWLOCK_BUG_ON(cond, lock, msg) \ > + if (unlikely(cond)) rwlock_bug(lock, __FILE__, __LINE__, msg)
I would suggest propagating the __FILE__ and __LINE__ from the CALLERS of those functions in lib/spinlock_debug.c into these macros, to make this info more useful. At the moment you just know, that the bug happend on some spinlock/rwlock, but not who caused this.
Regards
Ingo Oeser
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |