Messages in this thread |  | | | Date | Sun, 19 Jun 2005 21:49:55 +0200 | | From | Jesper Juhl <> | | Subject | Re: [PATCH] Small kfree cleanup, save a local variable. |
| |
On 6/19/05, Michael Buesch <mbuesch@freenet.de> wrote: > Quoting Jesper Juhl <juhl-lkml@dif.dk>: > > Here's a patch with a small improvement to kernel/auditsc.c . > > There's no need for the local variable struct audit_entry *e , > > we can just call kfree directly on container_of() . > > Did you look at the assembly output? Does it change? > I think the compiler optimizes this variable away, anyway. > So, if there's no improvement, I would personally prefer the > original form as it's more readable. > gcc does optimize it away. Personally I find both forms equally readable, and with the change the source matches what the code actually ends up as, but I don't care much one way or the other.
-- Jesper Juhl <jesper.juhl@gmail.com> Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please http://www.expita.com/nomime.html - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |