lkml.org 
[lkml]   [2005]   [Jun]   [17]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
FromDenis Vlasenko <>
Subject[PATCH] fealnx.c calls dev_kfree_skb from atomic context. fix it
DateFri, 17 Jun 2005 10:22:24 +0300
Hi Jeff,

Just a resend. Applies with offset to 2.6.12-rc2
--
vda
I believe I actually saw 'Badness' message because I used
wrong function.

No need to check and use exactly matching function,
This is not a fast path.

diff -urN linux-2.6.6-bk7.src/drivers/net/fealnx.c linux-2.6.6-bk7-fealnx.src/drivers/net/fealnx.c
--- linux-2.6.6-bk7.src/drivers/net/fealnx.c	Thu May 20 21:38:05 2004
+++ linux-2.6.6-bk7-fealnx.src/drivers/net/fealnx.c	Thu May 20 21:43:31 2004
@@ -1435,8 +1435,7 @@
 		if (cur->skbuff) {
 			pci_unmap_single(np->pci_dev, cur->buffer,
 				cur->skbuff->len, PCI_DMA_TODEVICE);
-			dev_kfree_skb(cur->skbuff);
-			/* or dev_kfree_skb_irq(cur->skbuff); ? */
+			dev_kfree_skb_any(cur->skbuff);
 			cur->skbuff = NULL;
 		}
 		cur->status = 0;
\
 
 \ /
  Last update: 2005-06-17 07:26    [from the cache]
©2003-2008