Messages in this thread | | | Date | Fri, 17 Jun 2005 10:56:17 -0700 | From | Zach Brown <> | Subject | Re: [patch] inotify, improved. |
| |
John McCutchan wrote:
> I really don't like sending partial events.
Partial reads, not partial events. Just like the previous code, it returns to userspace after copying the events it found in the list before it went empty. It doesn't go back to sleep to fill the rest of the buffer like a more classical blocking read() method would.
Where it differs is in what happens if you get errors copying events after having successfully copied some. The previous code would return the error, that patch would return the bytes used by the good events.
- z - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |