Messages in this thread | | | Date | Wed, 1 Jun 2005 11:29:06 +0200 | From | Pavel Machek <> | Subject | Re: [linux-pm] Re: [PATCH] Don't explode on swsusp failure to find swap |
| |
Hi!
> > More specifically, arch suspend calls swsusp_save(). > > > > It fails and returns the error to the arch asm code, which itself > > returns it to it's caller swsusp_suspend(), which does that: > > > > if ((error = swsusp_arch_suspend())) > > swsusp_free(); > I encounter a similar issue, when swsusp_swap_check failed. > It seems the swsusp_free isn't required in the failure case, > suspend_prepare_image has correctly handled the failure case to me. > Other arch? I wonder why swsusp_free is called after device_power_down > failed as well. No pages are allocated before device_power_down.
Agreed, its wrong. Also there's no reason for the swap check to be called (even indirectly) from arch code... Pavel - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |