Messages in this thread | | | Date | Sun, 08 May 2005 13:48:54 +0400 | From | Michael Tokarev <> | Subject | Re: [PATCH] Really *do* nothing in while loop |
| |
Thomas Glanzmann wrote: > [PATCH] Really *do* nothing in while loop > > Signed-Off-by: Thomas Glanzmann <sithglan@stud.uni-erlangen.de> > > --- a/sha1_file.c > +++ b/sha1_file.c > @@ -335,7 +335,7 @@ > stream.next_in = hdr; > stream.avail_in = hdrlen; > while (deflate(&stream, 0) == Z_OK) > - /* nothing */ > + /* nothing */; > > /* Then the data itself.. */ > stream.next_in = buf;
Well, the lack of semicolon is wrong really (and funny).
But is the whole while loop needed at all? deflate() consumes as much input as it can, producing as much output as it can. So without the loop, and without updating the buffer pointers ({next,avail}_{in,out}) it will do just fine without the loop, and will return something != Z_OK on next iteration. If this is to mean to flush output, it should be deflate(&stream, Z_FLUSH) or something.
/mjt
P.S. What's git@vger.kernel.org for ? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |