Messages in this thread | | | Date | Mon, 9 May 2005 00:03:04 +0200 (CEST) | From | Jesper Juhl <> | Subject | Re: [PATCH] kfree cleanups (remove redundant NULL checks) in drivers/telephony/ (actually ixj.c only) |
| |
On Sat, 7 May 2005, Jesper Juhl wrote:
> On Fri, 6 May 2005, Andrew Morton wrote: > > > > > This patch adds behavioural changes: > > [snip] > > Now we'll zero ->read_buffer_size even if ->read_buffer was already NULL. > > > > It's hard to believe that this could cause any problems, but please check > > that. > > > When I initially read the code I didn't see any harm that could be done by > that, but I'll take a second more careful look and report back - I'm > pretty sure it's safe though. > I'll do this tomorrow since I'm off to catch some sleep now. > Ok, I've taken a second look at the code, and I don't see any places where read_buffer_size are used where read_buffer is NULL, so zeroing read_buffer_size unconditionally when kfree()'ing read_buffer should be quite safe.
-- Jesper
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |